secret-sharing: Zeroize sensitive data #5928
Open
+858
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/trivial/churp-zeroize-secrets
branch
from
d0fabf6
to
cf516e0
Compare
PrimeField implements the Copy trait, which means values are copied when passed as parameters. To prevent sensitive data from being replicated, the switch point struct should accumulate points rather than coordinates.
The AddAssign, SubAssign, and MulAssign functions can now be used only when the prime field supports zeroization. This ensures that any leftover data from heap reallocation, when the right-hand-side polynomial has more coefficients than the left-hand-side, is zeroized. An alternative solution is to remove these functions, but this could lead to performance drawbacks.
peternose
force-pushed
the
peternose/trivial/churp-zeroize-secrets
branch
from
cf516e0
to
a3e8637
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5928 +/- ##
=======================================
Coverage 64.62% 64.62%
=======================================
Files 627 627
Lines 64292 64292
=======================================
+ Hits 41546 41550 +4
+ Misses 17823 17820 -3
+ Partials 4923 4922 -1 ☔ View full report in Codecov by Sentry. |
kostko
reviewed
Nov 6, 2024
|
|
||
| // Encrypt data using seal_into so that we can zeroize the plaintext. | ||
| let mut ciphertext = Vec::with_capacity(plaintext.len() + TAG_SIZE + NONCE_SIZE); | ||
| unsafe { ciphertext.set_len(plaintext.len() + TAG_SIZE) } |
There was a problem hiding this comment.
Why do you need unsafe here? Couldn't you just use ciphertext.resize instead?
|
|
||
| // Encrypt data using seal_into so that we can zeroize the plaintext. | ||
| let mut ciphertext = Vec::with_capacity(plaintext.len() + TAG_SIZE + NONCE_SIZE); | ||
| unsafe { ciphertext.set_len(plaintext.len() + TAG_SIZE) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.